fix: Update to support nyc 15. #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This configuration is no longer valid for nyc 14 and below.
|
Additional question, do you think this should have a peer dep on nyc >=15 or should that be done through documentation only? |
JaKXz
approved these changes
Dec 28, 2019
I agree that 1.0.0 should have the peer dep, unfortunately 1.0.0 was already published 8 days ago. So the question now do I publish this as 1.1.0 (treat 1.0.0 as a broken release) or do another semver-major to 2.0.0? |
|
Oh - then this should be a patch just so that people get the warning when they are installing v ^1.0.0 |
|
@JaKXz thanks for the review, 1.0.1 is now published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This configuration is no longer valid for nyc 14 and
below.
@JaKXz do you agree that this is a breaking change? Sorry I didn't catch this before releasing 1.0.0.