Report Logic Truthiness: Port over coverage lib changes. #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
reviewed
Oct 12, 2021
bcoe
reviewed
Oct 12, 2021
bcoe
requested changes
Oct 12, 2021
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
|
@bcoe |
|
@adrian-burlacu-software your work will be the next that I review, it's significant enough that I would like to test the branch against |
|
@adrian-burlacu-software I sent a PR with a few tweaks to this branch, if you merge we can land. |
tweaks to ensure change is non-breaking
|
@bcoe |
bcoe
approved these changes
Oct 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bcoe
This are the istanbul-lib-coverage changes to do with evaluating logical expression truthiness.
Blocking the original pull request until the version is published.
All tests pass.