Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for loading config from ESM modules #7

Merged
merged 2 commits into from Oct 5, 2019
Merged

feat: Add support for loading config from ESM modules #7

merged 2 commits into from Oct 5, 2019

Conversation

coreyfarrell
Copy link
Member

Fixes #6

@coreyfarrell
Copy link
Member Author

Tests were run locally using NODE_OPTIONS=--experimental-modules npm t on node 10 and 12. In that case coverage is 100%. I think when node.js unflags ESM then we'll add a version-check to nyc-settings.js which will enforce 100% coverage for unflagged versions.

Note nyc-settings.js was used here since it doesn't match a default config so it doesn't interfere with the tests.

@coreyfarrell coreyfarrell merged commit bc5ea3e into istanbuljs:master Oct 5, 2019
@coreyfarrell coreyfarrell deleted the async-esm branch October 5, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Async API / Support loading config from ESM
1 participant
@coreyfarrell