Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pass extension to test-exclude, use TestExclude.globSync. #1026

Merged
merged 1 commit into from Mar 18, 2019

Conversation

coreyfarrell
Copy link
Member

BREAKING CHANGE: The logic involving include/exclude processing has
changed. Results should be verified to ensure all desired sources have
coverage data.

BREAKING CHANGE: The logic involving include/exclude processing has
changed.  Results should be verified to ensure all desired sources have
coverage data.
@coreyfarrell
Copy link
Member Author

The testing changes are less significant than it looks. The tests were actually checking for results that were impossible in practice. Although shouldInstrument('file-without-extension') could previously return true, the file would never have been instrumented because it has no extension for the require hook.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 93.898% when pulling 651eced on coreyfarrell:updated-test-exclude into d8f28e9 on istanbuljs:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 93.898% when pulling 651eced on coreyfarrell:updated-test-exclude into d8f28e9 on istanbuljs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 93.898% when pulling 651eced on coreyfarrell:updated-test-exclude into d8f28e9 on istanbuljs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 93.898% when pulling 651eced on coreyfarrell:updated-test-exclude into d8f28e9 on istanbuljs:master.

@coreyfarrell coreyfarrell merged commit aae5a59 into istanbuljs:master Mar 18, 2019
@coreyfarrell coreyfarrell deleted the updated-test-exclude branch March 18, 2019 21:59
@coreyfarrell coreyfarrell mentioned this pull request Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants