Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rename plugins option to parser-plugins. #1031

Merged
merged 1 commit into from Mar 18, 2019

Conversation

coreyfarrell
Copy link
Member

The original option name created confusion about what was expected.
This helps identify that babel parser plugins are expected, not babel
transform plugins.

BREAKING CHANGE: The plugins option has been renamed to
parser-plugins.

Fixes #986

The original option name created confusion about what was expected.
This helps identify that babel parser plugins are expected, not babel
transform plugins.

BREAKING CHANGE: The `plugins` option has been renamed to
`parser-plugins`.

Fixes istanbuljs#986
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.296% when pulling 9ff5d66 on coreyfarrell:parser-plugins into 364eb33 on istanbuljs:master.

@JaKXz
Copy link
Member

JaKXz commented Mar 17, 2019

@coreyfarrell do we have an nyc@14 branch to merge breaking changes to and rebase eventually?

@coreyfarrell
Copy link
Member Author

@JaKXz master already has one breaking change merged and #1026 is being labeled as breaking to be on the safe side. The plan is that the next release will be 14.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants