feat: add --exclude-after-remap option for users who pre-instrument their codebase #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 22, 2017 15:07
kentcdodds
approved these changes
Oct 23, 2017
| @@ -320,9 +331,18 @@ You can specify custom high and low watermarks in nyc's configuration: | |||
| } | |||
| ``` | |||
|
|
|||
| ## Other advanced features | |||
| ## Parsing Hints (Ignoring Lines) | |||
There was a problem hiding this comment.
This whole section looks good to me 👍
ljharb
approved these changes
Oct 23, 2017
| @@ -96,7 +96,7 @@ | |||
| "resolve-from": "^2.0.0", | |||
| "rimraf": "^2.5.4", | |||
| "signal-exit": "^3.0.1", | |||
| "spawn-wrap": "^1.4.0", | |||
| "spawn-wrap": "1.3.8", | |||
There was a problem hiding this comment.
i've noticed some weirdness around pinning versions in npm 5; using =1.3.8 seems to avoid it
There was a problem hiding this comment.
Is there a reason spawn-wrap was downgraded? There is a fix in version 1.4.0 that can be useful for people that want to run nyc in a container.
The issue in question: istanbuljs/spawn-wrap#49
This was referenced Oct 29, 2017
Closed
|
I can confirm this fixed issues I was seeing with folders being specified for instrumentation/instrumentering |
This was referenced Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem Being Addressed
If someone is running tests against files that have been pre-instrumented in a codebase with corresponding source-maps (rather than using a JIT transpiler like babel-register) the a source-map will sometimes result in a source-files path being remapped to a folder that is covered by an exclude rule.
A user can now disable this behavior by setting
--exclude-after-remaptofalse, which will stop exclude logic from being applied after the application ofsource-maps.In This Pull Request
--exclude-after-remapcaveat.spawn-wrapbecause it was creatingundefinedfolders while I attempted to test things; I've filed an issue.@thegecko I think there's a good chance that the behavior around source-map remapping was the root cause of your issues. The more I think about #696, I don't think there's any reason why we should need to use the relative path rather than the absolute path to the file ... there's a chance however this might have stepped around the issues described in this pull request.
@ljharb perhaps you'd like to take a quick look at this pull too -- I forget, I think you might have been bumping into something related to this?