Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 2.x compatibility #54

Closed
GabeMedrash opened this issue Mar 16, 2016 · 4 comments
Closed

Webpack 2.x compatibility #54

GabeMedrash opened this issue Mar 16, 2016 · 4 comments

Comments

@GabeMedrash
Copy link
Contributor

So far as I can tell, in Webpack 2.x, --colors is no longer a valid CLI option. --color is now the supported option. Running this plugin using Webpack 2.1.0-beta.4 (current as of today) produces a huge console error, though the meat of it is: Unknown argument: colors.

Changing the option to --color in lib/runWebPackSync.js fixes the issue, though I'm assuming would break compatibility with Webpack 1.x.

@istarkov
Copy link
Owner

Looks like removing colors options will not break anything. You could provide a PR, and I feel all tests will be completed. So if no issues will be in tests I'll accept your PR.

@GabeMedrash
Copy link
Contributor Author

Thanks, @istarkov. Just submitted the suggested PR.

@istarkov
Copy link
Owner

Thank you!!!! Published as 0.3.10

@GabeMedrash
Copy link
Contributor Author

You're awesome--thanks so much for the quick response and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants