Deploy codesandbox example to gh-pages #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrySound
reviewed
May 26, 2019
package.json
Outdated
| @@ -17,7 +17,9 @@ | |||
| "jest": "NODE_ICU_DATA=`yarn -s run node-full-icu-path` jest", | |||
| "test": "eslint ./ && flow check && yarn test:ts && yarn jest", | |||
| "test:ts": "tslint -p tsconfig.json", | |||
| "deploy": "yarn next build && yarn next export && gh-pages -d out", | |||
| "copy-sandbox-examples": "mkdir -p ./out/pages && find ./pages -type d -mindepth 1 -maxdepth 1 -exec cp -R \\{\\} ./out/pages \\;", | |||
There was a problem hiding this comment.
Maybe rename to codesandboxes then?
There was a problem hiding this comment.
I meant rename dist folder to codesandboxes. pages doesn't make much sense in gh-pages
TrySound
reviewed
May 26, 2019
next.config.js
Outdated
| const rifmPath = | ||
| process.env.NODE_ENV === 'production' | ||
| ? './dist/rifm.esm.js' | ||
| : './src/index.js'; |
There was a problem hiding this comment.
Does source work without next babel config extension?
There was a problem hiding this comment.
Yep it works, even reloads on change
There was a problem hiding this comment.
Then let's consume only src. I used dist to consume released version.
TrySound
approved these changes
May 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.