/
no_short.go
44 lines (37 loc) · 1.3 KB
/
no_short.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
// Copyright 2018 Istio Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package rules
import (
"go/ast"
"go/token"
"istio.io/istio/tests/util/checker"
)
// NoShort requires that testing.Short() is not allowed.
type NoShort struct{}
// NewNoShort creates and returns a NoShort object.
func NewNoShort() *NoShort {
return &NoShort{}
}
// GetID returns no_short_rule.
func (lr *NoShort) GetID() string {
return GetCallerFileName()
}
// Check verifies if aNode is not testing.Short(). If verification lrp creates new report.
func (lr *NoShort) Check(aNode ast.Node, fs *token.FileSet, lrp *checker.Report) {
if ce, ok := aNode.(*ast.CallExpr); ok {
if MatchCallExpr(ce, "testing", "Short") {
lrp.AddItem(fs.Position(ce.Pos()), lr.GetID(), "testing.Short() is disallowed.")
}
}
}