Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate if we can enable includeInboundPort by default #15834

Closed
linsun opened this issue Jul 25, 2019 · 3 comments
Closed

Evaluate if we can enable includeInboundPort by default #15834

linsun opened this issue Jul 25, 2019 · 3 comments

Comments

@linsun
Copy link
Member

linsun commented Jul 25, 2019

Describe the feature request
A few of our users spent long time to debug istio issues this week where they had forgot to declare container port and mTLS doesn't work.

We need to identify gaps and additional automated test to ensure our newly added “traffic.sidecar.istio.io/includeInboundPorts” is working and can be enabled by default in 1.3 (or at least 1.4). Per release note of 1.2 (https://istio.io/about/notes/1.2/), this is a future direction the community would like to take anyway.

Describe alternatives you've considered
declare container port manually or add the includeInboundPort annotation mannually

Affected product area (please put an X in all that apply)

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[x ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

cc @esnible @huang195 @rvennam @sdake @duderino

@linsun
Copy link
Member Author

linsun commented Jul 25, 2019

@johnma14 could you do some investigation on this and report back?

@costinm
Copy link
Contributor

costinm commented Aug 21, 2019

The feature is implemented in 1.3 and we are planning to enable it by default in master - the main gap is testing, in particular around security.

@lambdai - can you link the current tests and docs / options ?

@johnma14
Copy link
Contributor

@linsun This work has been captured under the PR's mentioned in this WI: #6259. The annotation was enabled by default in this PR: istio/installer#355. Closing this WI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants