Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixer StackDriver adapter: re-encode strings as utf8 #16966

Closed
mandarjog opened this issue Sep 10, 2019 · 1 comment · Fixed by #17114
Closed

Mixer StackDriver adapter: re-encode strings as utf8 #16966

mandarjog opened this issue Sep 10, 2019 · 1 comment · Fixed by #17114
Assignees
@douglas-reid
Labels
area/extensions and telemetry kind/customer issue
Milestone
1.4

Comments

@mandarjog
Copy link
Contributor

The following error was seen when Mixer sent invalid utf-8 to SD.
rpc error: code = Internal desc = grpc: error while marshaling: proto: field "google.logging.v2.LogEntry.Labels" contains invalid UTF-8 {"adapter": "handler.stackdriver.istio-system"}

The following unsanitized user agent string caused the issue.

User-Agent: Mozilla/5.0 (iPhone; CPU iPhone OS 12_1_4 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/16D57�

This should be fixed in the SD adapter.
@mandarjog mandarjog added this to the 1.4 milestone Sep 10, 2019
@mandarjog
Copy link
Contributor Author

This fix should be backported to 1.2

@douglas-reid douglas-reid mentioned this issue Sep 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@douglas-reid douglas-reid

Labels
area/extensions and telemetry kind/customer issue
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

fix(stackdriver adapter): strip bad utf8 in log text douglas-reid/istio
3 participants
@mandarjog @douglas-reid @bianpengyuan