Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

istioctl doesn't validate networking.istio.io/v1beta1 rules #24064

Closed
esnible opened this issue May 24, 2020 · 0 comments · Fixed by #24065
Closed

istioctl doesn't validate networking.istio.io/v1beta1 rules #24064

esnible opened this issue May 24, 2020 · 0 comments · Fixed by #24065
Assignees
@esnible
Labels
area/user experience

Comments

@esnible
Copy link
Contributor

esnible commented May 24, 2020

To reproduce I used master and also 1.5.4.

istioctl validate -f galley/testdatasets/validation/dataset/networking-v1beta-DestinationRule-invalid.yaml
"galley/testdatasets/validation/dataset/networking-v1beta-DestinationRule-invalid.yaml" is valid
$ kubectl apply -f galley/testdatasets/validation/dataset/networking-v1beta-DestinationRule-invalid.yaml
Error from server: error when creating "galley/testdatasets/validation/dataset/networking-v1beta-DestinationRule-invalid.yaml": admission webhook "validation.istio.io" denied the request: configuration is invalid: empty domain name not allowed

Discovered while troubleshooting #24041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esnible esnible

Labels
area/user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't skip networking.istio.io/v1beta1 for "istioctl validate -f" esnible/istio
1 participant
@esnible