Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart needs automation for mutating webhooks #3018

Closed
sdake opened this issue Jan 31, 2018 · 3 comments
Closed

Helm chart needs automation for mutating webhooks #3018

sdake opened this issue Jan 31, 2018 · 3 comments

Comments

@sdake
Copy link
Member

sdake commented Jan 31, 2018

I'm not totally convinced the current Helm chart follows the workflow for automatic sidecar injection (for Kubernetes 1.9) as documented here:

https://istio.io/docs/setup/kubernetes/sidecar-injection.html
(make sure to scroll down to the automatic injection part)

To be fair, this documentation just recently hit the repo and took me awhile to understand :)

@luisyonaldo you seem to be rocking the charts, care to take a first look at the implementation work here?

cc @linsun @luisyonaldo @sbezverk

@luisyonaldo
Copy link
Contributor

great that you point me to that document. I was working in the dark with the helm chart for the sidecar-injection 👍

@costinm costinm added this to the Istio 0.7 milestone Feb 22, 2018
@sdake sdake changed the title Helm chart needs attention for mutating web hooks Helm chart needs automation for mutating webhooks Mar 18, 2018
@sdake sdake self-assigned this Mar 18, 2018
@sdake
Copy link
Member Author

sdake commented Mar 18, 2018

apologies about all the noise; computer problems are triggering clicks randomly of my mouse.

@ayj ayj assigned yusuoh and unassigned ayj Mar 21, 2018
@sdake
Copy link
Member Author

sdake commented Apr 8, 2018

@yusuoh has solved this problem in a general way. He also added some work to fully integrate with hem.

@sdake sdake closed this as completed Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants