Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recommended to add telemetry analyzer #43705

Closed
zengyuxing007 opened this issue Mar 2, 2023 · 3 comments
Closed

recommended to add telemetry analyzer #43705

zengyuxing007 opened this issue Mar 2, 2023 · 3 comments

Comments

@zengyuxing007
Copy link
Contributor

Describe the feature request

The Telemetry documentation describes how to use telemetry, but in practice, if you don't read the documentation carefully, it's easy to fall into the pit and users will obsess about what went wrong because they didn't achieve the expected results.

The following two points are easily overlooked by users

  • For any namespace, including the root configuration namespace, it is only valid to have a single workload selector-less Telemetry resource.
  • For resources with a workload selector, it is only valid to have one resource selecting any given workload.

It is recommended to add a diagnosis

[ ] Ambient
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[X ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Affected features (please put an X in all that apply)

[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane

Additional context

@zengyuxing007
Copy link
Contributor Author

If you want to configure a global Trace and Metrics, you must write them under a Telemetry CR. Instead of
write them under two separate Telemetry CRs like below.

apiVersion: telemetry.istio.io/v1alpha1
kind: Telemetry
metadata:
  name: global-metrics
  namespace: istio-system
spec:
  metrics:
  - providers:
    - name: prometheus
    overrides:
    - match:
        metric: ALL_METRICS
        mode: CLIENT_AND_SERVER
      disabled: false
apiVersion: telemetry.istio.io/v1alpha1
kind: Telemetry
metadata:
  name: global-trace
  namespace: istio-system
spec:
  tracing:
  - randomSamplingPercentage: 10.00
    customTags:
      my_new_foo_tag:
        literal:
          value: "foo"

If you write them separately, the result is undefined. (The one configured at the earliest time will take effect)

@Kaushal28
Copy link
Contributor

Hi @zirain , I would like to contribute here, could you please provide me with some more details/examples if you have or any entry point from where I can start?

@hanxiaop
Copy link
Member

hanxiaop commented Mar 4, 2023

Finished by #43706

@hanxiaop hanxiaop closed this as completed Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants