Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

istiod-default-validator missing if use operator installed istio #43893

Closed
3 of 16 tasks
kebe7jun opened this issue Mar 13, 2023 · 1 comment · Fixed by #43897
Closed
3 of 16 tasks

istiod-default-validator missing if use operator installed istio #43893

kebe7jun opened this issue Mar 13, 2023 · 1 comment · Fixed by #43897
Assignees
Labels
area/environments/operator Issues related to Operator or installation

Comments

@kebe7jun
Copy link
Member

Bug Description

The operator and istioctl do not have the same behavior for processing validatingwebhookconfigurations during installation

These logics missing in opetator logic:

if !operatorManageWebhooks && (!exists || isDefaultInstallation) {
p.Println("Making this installation the default for injection and validation.")
if rev == "" {
rev = revtag.DefaultRevisionName
}
autoInjectNamespaces := validateEnableNamespacesByDefault(iop)
o := &revtag.GenerateOptions{
Tag: revtag.DefaultRevisionName,
Revision: rev,
Overwrite: true,
AutoInjectNamespaces: autoInjectNamespaces,
}
// If tag cannot be created could be remote cluster install, don't fail out.
tagManifests, err := revtag.Generate(context.Background(), kubeClient, o, ns)
if err == nil {
err = revtag.Create(kubeClient, tagManifests)
if err != nil {
return err
}
}
}

Version

master

Additional Information

No response

Affected product area

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Upgrade
  • Multi Cluster
  • Virtual Machine
  • Control Plane Revisions

Is this the right place to submit this?

  • This is not a security vulnerability
  • This is not a question about how to use Istio
@hanxiaop hanxiaop self-assigned this Mar 13, 2023
@kebe7jun
Copy link
Member Author

kebe7jun commented Mar 13, 2023

This causes the creation of the Istio resource validation fail, except force the istio.io/rev to default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/environments/operator Issues related to Operator or installation
Projects
None yet
2 participants