Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward B3 tracing headers in envoyExtAuthzHttp side requests #47278

Closed
TimJongerius opened this issue Oct 10, 2023 · 6 comments
Closed

Forward B3 tracing headers in envoyExtAuthzHttp side requests #47278

TimJongerius opened this issue Oct 10, 2023 · 6 comments
Labels
area/networking kind/enhancement lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while

Comments

@TimJongerius
Copy link

Describe the feature request

Can we have the B3 tracing headers added to the envoyExtAuthzHttp side requests? It would be helpful to see these requests in Jaeger.

Describe alternatives you've considered

Affected product area (please put an X in all that apply)

[ ] Ambient
[ ] Docs
[ ] Dual Stack
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Affected features (please put an X in all that apply)

[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane

Additional context

@hzxuzhonghu
Copy link
Member

We have MeshConfig_ExtensionProvider_EnvoyExternalAuthorizationHttpProvider.IncludeRequestHeadersInCheck, could this satisfy your case
`

@TimJongerius
Copy link
Author

I’ve tried this but the headers aren’t forwarded to the oauth proxy. My guess would be that the ingress gateway creates the B3 headers after the authentication was successful before routing the request upstream.

@hzxuzhonghu
Copy link
Member

Yes, B3 is generated after ext-auth

@TimJongerius
Copy link
Author

Is there a way to have the gateway create B3 before authz? Maybe you can get me started with an EnvoyFilter.

@hzxuzhonghu
Copy link
Member

I believe there is no way that you can get B3 header before it is generated, this is in gateway. But you can get it on the backend server side as the B3 headers will be sent to server.

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Apr 15, 2024
@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2023-10-17. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking kind/enhancement lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while
Projects
None yet
Development

No branches or pull requests

3 participants