Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for readiness probe options for pilot in the helm chart #47310

Closed
brettcurtis opened this issue Oct 11, 2023 · 3 comments
Closed

Support for readiness probe options for pilot in the helm chart #47310

brettcurtis opened this issue Oct 11, 2023 · 3 comments
Labels
area/environments kind/enhancement lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while

Comments

@brettcurtis
Copy link

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)

Describe the feature request
I see readiness probe options in the values for:

global:
   proxy:
      readinessPeriodSeconds: 2

I'd like to change the readiness probe values for the istiod deployment tho, am I missing something here? The reason I'm looking for this is because I'm trying to to use GKE multi-cluster-services and export the istiod service and Google is requiring that the TimeoutSeconds must be less than or equal to PeriodSeconds.

status:
  conditions:
  - lastTransitionTime: "2023-09-26T11:22:11Z"
    status: "True"
    type: Initialized
  - lastTransitionTime: "2023-09-26T21:12:24Z"
    message: '&ServicePort{Name:grpc-xds,Protocol:TCP,Port:15010,TargetPort:{0 15010
      },NodePort:0,AppProtocol:nil,} has error: invalid ReadinessProbe configuration:
      TimeoutSeconds must be less than or equal to PeriodSeconds;&ServicePort{Name:https-webhook,Protocol:TCP,Port:443,TargetPort:{0
      15017 },NodePort:0,AppProtocol:nil,} has error: invalid ReadinessProbe configuration:
      TimeoutSeconds must be less than or equal to PeriodSeconds'
    reason: ReadinessProbeError
    status: "False"
    type: Exported

I don't know if this a standard k8s deploy thing or something MCS is requiring specifically.

Describe alternatives you've considered

Patch deployment or extend chart.

Affected product area (please put an X in all that apply)

[ ] Ambient
[ ] Docs
[ ] Dual Stack
[ X ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Affected features (please put an X in all that apply)

[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane

Additional context

@brettcurtis
Copy link
Author

Maybe it's fair to just request that the TimeoutSeconds should be less than or equal to PeriodSeconds?

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Apr 9, 2024
@brettcurtis
Copy link
Author

Is this something that might be a good add to the chart or am I misunderstanding the current implementation?

@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2023-10-11. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/environments kind/enhancement lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while
Projects
None yet
Development

No branches or pull requests

2 participants