Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multicluster leader election does not work well #47901

Closed
hzxuzhonghu opened this issue Nov 17, 2023 · 0 comments · Fixed by #47873
Closed

Multicluster leader election does not work well #47901

hzxuzhonghu opened this issue Nov 17, 2023 · 0 comments · Fixed by #47873

Comments

@hzxuzhonghu
Copy link
Member

istio/pilot/pkg/leaderelection/leaderelection.go

Lines 228 to 230 in b71a015

func NewLeaderElectionMulticluster(namespace, name, electionID, revision string, remote bool, client kube.Client) *LeaderElection {
return newLeaderElection(namespace, name, electionID, revision, false, true, client)
}

The param remote means it is not the config cluster, but it is not passed down, so the leader election does not work well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix multicluster leader election regression hzxuzhonghu/istio
1 participant
@hzxuzhonghu