Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

istioctl uninstall with files is broken #47960

Closed
2 tasks done
hanxiaop opened this issue Nov 21, 2023 · 0 comments · Fixed by #47961
Closed
2 tasks done

istioctl uninstall with files is broken #47960

hanxiaop opened this issue Nov 21, 2023 · 0 comments · Fixed by #47961
Assignees

Comments

@hanxiaop
Copy link
Member

hanxiaop commented Nov 21, 2023

Is this the right place to submit this?

  • This is not a security vulnerability or a crashing bug
  • This is not a question about how to use Istio

Bug Description

Currently, I'm installing the Istio using a custom file with istioctl install -f custom.yaml. When I execute istioctl uninstall -r revision, the components are removed as expected, but this command removes all resources in a specific revision.

When I try to execute istioctl uninstall -r revision -f custom.yaml to remove the actual overlaid IOP resources, only Istiod is removed. The CNI and ztunnel, which were installed with istioctl install -f custom.yaml, remain in the cluster.

The expected behavior is that the uninstall command can correctly clean up the resources specified in my overlaid IOP file.

To reproduce:

 istioctl install -f out/yamls/overlay.yaml  
This will install the Istio 1.21.0 "ambient" profile (with components: Istio core, Istiod, CNI, and Ztunnel) into the cluster. Proceed? (y/N) y
✔ Istio core installed                                                                                                                                                                
✔ Istiod installed                                                                                                                                                                    
✔ CNI installed                                                                                                                                                                       
✔ Ztunnel installed                                                                                                                                                                   
✔ Installation complete                                                                                                                                                               
Made this installation the default for injection and validation.
➜  istio git:(master) ki get po
NAME                      READY   STATUS    RESTARTS   AGE
istio-cni-node-cblw8      1/1     Running   0          25h
istio-cni-node-lvpc4      1/1     Running   0          25h
istio-cni-node-tmwlr      1/1     Running   0          25h
istiod-5db7969449-6q8l4   1/1     Running   0          112m
jaeger-7d7d59b9d-hvb2g    1/1     Running   0          4d1h
ztunnel-4sj7l             1/1     Running   0          25h
ztunnel-rm5dz             1/1     Running   0          25h
ztunnel-tzd5k             1/1     Running   0          25h
➜  istio git:(master) istioctl uninstall -f out/yamls/overlay.yaml --revision=default
  Removed HorizontalPodAutoscaler:istio-system:istiod.
  Removed ClusterRole::istiod-clusterrole-istio-system.
  Removed ClusterRole::istiod-gateway-controller-istio-system.
  Removed ClusterRoleBinding::istiod-clusterrole-istio-system.
  Removed ClusterRoleBinding::istiod-gateway-controller-istio-system.
  Removed ConfigMap:istio-system:istio.
  Removed Deployment:istio-system:istiod.
  Removed ConfigMap:istio-system:istio-sidecar-injector.
  Removed MutatingWebhookConfiguration::istio-sidecar-injector.
  Removed PodDisruptionBudget:istio-system:istiod.
  Removed ClusterRole::istio-reader-clusterrole-istio-system.
  Removed ClusterRoleBinding::istio-reader-clusterrole-istio-system.
  Removed Role:istio-system:istiod.
  Removed RoleBinding:istio-system:istiod.
  Removed Service:istio-system:istiod.
  Removed ServiceAccount:istio-system:istiod.
  Removed ValidatingWebhookConfiguration::istio-validator-istio-system.
✔ Uninstall complete                                                                                                                                                                  ➜  istio git:(master) ki get po
NAME                     READY   STATUS    RESTARTS   AGE
istio-cni-node-cblw8     1/1     Running   0          25h
istio-cni-node-lvpc4     1/1     Running   0          25h
istio-cni-node-tmwlr     1/1     Running   0          25h
jaeger-7d7d59b9d-hvb2g   1/1     Running   0          4d1h
ztunnel-4sj7l            1/1     Running   0          25h
ztunnel-rm5dz            1/1     Running   0          25h
ztunnel-tzd5k            1/1     Running   0          25h

Version

master

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants