-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the ambient/getting-started
istio.io tests
#50145
Comments
One thing I noted is this cmd output needs to be updated:
as of latest master, this returns number of pods vs true|false.
|
Hi @ilrudie I tried to enable test in istio/istio.io#14922 as it seem to work pretty well when i tested manually. |
Sounds good. I will take a look at your pr shortly! |
This test has not been enabled, so re-opening. |
ops/ambient/getting-started
istio.io testsambient/getting-started
istio.io tests
Sorry I misunderstood the issue. I had thought it is the tests button in the doc, but it is not. @ilrudie give this back to you :) |
Just enabling the tests to see if they maybe work in istio/istio.io#14941 |
There are test failures noted in that PR. One may be a needed test framework update, but also it seems that some renumbering was done in the snippets in another PR which need to be pulled into the tests. Since the testing was disabled, the renumbering is uncovered until now. |
Thanks Eric. I will take a look shortly |
@ilrudie You can start with my PR. It should have a good start for the test.sh, but might need some renumbering/changes in the gtw_test.sh. If my verify fix PR isn't merged, just grab the one line change in verify.sh to make headway. |
@ericvn, ty. |
Closed by istio/istio.io#14953 |
Is this the right place to submit this?
Bug Description
Tests get (ex: https://gcsweb.istio.io/gcs/istio-prow/pr-logs/pull/istio_istio.io/14775/doc.test.profile-none_istio.io/1773380790281834496/artifacts/tests-setup-profile-none-f8b3f6/TestDocs/ops/ambient/getting-started/test.sh/test.sh/_test_context):
Version
Additional Information
No response
The text was updated successfully, but these errors were encountered: