Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the ambient/getting-started istio.io tests #50145

Closed
2 tasks done
ericvn opened this issue Mar 28, 2024 · 11 comments · Fixed by istio/istio.io#14922
Closed
2 tasks done

Enable the ambient/getting-started istio.io tests #50145

ericvn opened this issue Mar 28, 2024 · 11 comments · Fixed by istio/istio.io#14922
Assignees
Labels
Ambient Beta Must have for Beta of Ambient Mesh area/networking
Milestone

Comments

@ericvn
Copy link
Contributor

ericvn commented Mar 28, 2024

Is this the right place to submit this?

  • This is not a security vulnerability or a crashing bug
  • This is not a question about how to use Istio

Bug Description

Tests get (ex: https://gcsweb.istio.io/gcs/istio-prow/pr-logs/pull/istio_istio.io/14775/doc.test.profile-none_istio.io/1773380790281834496/artifacts/tests-setup-profile-none-f8b3f6/TestDocs/ops/ambient/getting-started/test.sh/test.sh/_test_context):

VERIFY FAILED snip_layer_7_authorization_policy_4 (timeout after 120s):
received:
"upstream connect error or disconnect/reset before headers. reset reason: connection termination"
expected:
"RBAC: access denied"

Version

main istio branch

Additional Information

No response

@linsun
Copy link
Member

linsun commented Apr 18, 2024

One thing I noted is this cmd output needs to be updated:

kubectl logs ds/ztunnel -n istio-system  | grep inpod_enabled

as of latest master, this returns number of pods vs true|false.

Found 3 pods, using pod/ztunnel-lg4ft

@linsun
Copy link
Member

linsun commented Apr 19, 2024

Hi @ilrudie I tried to enable test in istio/istio.io#14922 as it seem to work pretty well when i tested manually.

@ilrudie
Copy link
Contributor

ilrudie commented Apr 22, 2024

Sounds good. I will take a look at your pr shortly!

Prioritization automation moved this from Release Blocker to Done Apr 22, 2024
@ericvn
Copy link
Contributor Author

ericvn commented Apr 23, 2024

This test has not been enabled, so re-opening.

@ericvn ericvn reopened this Apr 23, 2024
@ericvn ericvn moved this from Done to Release Blocker in Prioritization Apr 23, 2024
@ericvn ericvn changed the title Enable the ops/ambient/getting-started istio.io tests Enable the ambient/getting-started istio.io tests Apr 23, 2024
@linsun
Copy link
Member

linsun commented Apr 23, 2024

Sorry I misunderstood the issue. I had thought it is the tests button in the doc, but it is not. @ilrudie give this back to you :)

@ericvn
Copy link
Contributor Author

ericvn commented Apr 23, 2024

Just enabling the tests to see if they maybe work in istio/istio.io#14941

@ericvn
Copy link
Contributor Author

ericvn commented Apr 23, 2024

There are test failures noted in that PR. One may be a needed test framework update, but also it seems that some renumbering was done in the snippets in another PR which need to be pulled into the tests. Since the testing was disabled, the renumbering is uncovered until now.

@ilrudie
Copy link
Contributor

ilrudie commented Apr 23, 2024

Thanks Eric. I will take a look shortly

@ericvn
Copy link
Contributor Author

ericvn commented Apr 23, 2024

@ilrudie You can start with my PR. It should have a good start for the test.sh, but might need some renumbering/changes in the gtw_test.sh. If my verify fix PR isn't merged, just grab the one line change in verify.sh to make headway.

@ilrudie
Copy link
Contributor

ilrudie commented Apr 23, 2024

@ericvn, ty.

@ilrudie
Copy link
Contributor

ilrudie commented Apr 24, 2024

Closed by istio/istio.io#14953

@ilrudie ilrudie closed this as completed Apr 24, 2024
Prioritization automation moved this from Release Blocker to Done Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ambient Beta Must have for Beta of Ambient Mesh area/networking
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants