Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backporting the fix #48147 to 1.19, 1.20 Istio versions #50642

Open
2 tasks done
jeswinkoshyninan opened this issue Apr 23, 2024 · 4 comments
Open
2 tasks done

Backporting the fix #48147 to 1.19, 1.20 Istio versions #50642

jeswinkoshyninan opened this issue Apr 23, 2024 · 4 comments
Labels
area/environments area/upgrade Issues related to upgrades

Comments

@jeswinkoshyninan
Copy link

jeswinkoshyninan commented Apr 23, 2024

Is this the right place to submit this?

  • This is not a security vulnerability or a crashing bug
  • This is not a question about how to use Istio

Bug Description

It is noted that 1.19 is introduced with webhooks by default as per #43897 and the upgrades are ending up with failures because of webhook conflict issue as fixed here #48147. I think it is much better to backporting the fix to the version 1.19 and 1.20 to avoid creating the issue as mentioned.

Version

$istioctl version
client version: 1.19.9
control plane version: 1.19.9
data plane version: 1.19.9
$kubectl version
Client Version: v1.27.4
Server Version: v1.27.4

Additional Information

No response

@istio-policy-bot istio-policy-bot added area/environments area/upgrade Issues related to upgrades labels Apr 23, 2024
@jeswinkoshyninan jeswinkoshyninan changed the title Backporting the fix #48147. to 1.19, 1.20 Istio versions Backporting the fix #48147 to 1.19, 1.20 Istio versions Apr 23, 2024
@kfaseela
Copy link
Member

@hanxiaop mind taking a look?

@hanxiaop
Copy link
Member

The first PR was trying to fix a different issue, where successfully installing the operator didn’t go with the validation webhook, and it didn’t change the confliction behavior. The fixes related to the confliction were to make the installation process smoother, but IIRC there were 2 to 3 related PRs, which involves both webhook and the webhook analyzer logics, and that may not be done easily.

I think If we want to backport PRs, we can do for 1.20 maybe, in case if there are any regressions from the backport and 1.19 is EOL and doesn't accept PRs anymore.

@jeswinkoshyninan
Copy link
Author

@hanxiaop thank you for comments, sounds good. I hope this will backport in 1.20?

@jeswinkoshyninan
Copy link
Author

jeswinkoshyninan commented Apr 25, 2024

@hanxiaop once you confirm, please let me know once you confirm that this is possible . Also confirm if upgrading from 1.18 to 1.20 is possible. I knew that this is not recommended but still checking for options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/environments area/upgrade Issues related to upgrades
Projects
None yet
Development

No branches or pull requests

4 participants