Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate on branching added extra image: field on jobs pointing to master #3792

Open
ericvn opened this issue Jan 21, 2022 · 4 comments
Open

generate on branching added extra image: field on jobs pointing to master #3792

ericvn opened this issue Jan 21, 2022 · 4 comments
Labels
area/test and release

Comments

@ericvn
Copy link
Contributor

ericvn commented Jan 21, 2022

This image overrides the image being updated to the release at the top of each file.
@ericvn
Copy link
Contributor Author

ericvn commented Apr 22, 2022

Still exists for the 1.14 branching.

@ericvn
Copy link
Contributor Author

ericvn commented Oct 19, 2022

Example:

- name: BUILD_WITH_CONTAINER
  value: "0"
image: gcr.io/istio-testing/build-tools:release-1.16-6363b97c6bc60b7a3a8d52c5e08322d8394149e2
jobs:
- command:
  - make
  - build
  env:
  - name: BUILD_WITH_CONTAINER
    value: "0"
  - name: BUILD_WITH_CONTAINER
    value: "0"
  image: gcr.io/istio-testing/build-tools:master-6363b97c6bc60b7a3a8d52c5e08322d8394149e2

You can see the overall master was updated to 1.16, but the individual jobs still have master`.

@ericvn
Copy link
Contributor Author

ericvn commented Dec 8, 2023

You also see BUILD_WITH_CONTAINER appearing twice within a job.

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Mar 13, 2024
@ericvn
Copy link
Contributor Author

ericvn commented Apr 15, 2024

Would still be good to get this done.

@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/test and release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericvn @istio-policy-bot