New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script simplification suggestion/idea #1

Closed

ReenigneArcher opened this issue Oct 25, 2022 · 1 comment

ReenigneArcher commented Oct 25, 2022

Easy-Tan/sunshine-flatpak-installer.sh

Lines 7 to 9 in 62ddf0e

    
           echo 'KERNEL=="uinput", GROUP="input", MODE="0660", OPTIONS+="static_node=uinput"' > 85-sunshine-input.rules 
        
           sudo cp 85-sunshine-input.rules /etc/udev/rules.d/85-sunshine-input.rules 
        
           rm 85-sunshine-input.rules

You don't need to create a temp file, copy, then delete it.

You can do something like this https://github.com/LizardByte/Sunshine/blob/894cb6507eed5e3317fb91072e3429cbba6f3ab0/packaging/linux/AppImage/AppRun#L50

echo 'KERNEL=="uinput", GROUP="input", MODE="0660", OPTIONS+="static_node=uinput"' | sudo tee /etc/udev/85-sunshine.rules

Owner

istori1 commented Oct 25, 2022

Added to main branch

https://github.com/istori1/Easy-Tan/blob/main/sunshine-flatpak-installer.sh#L7

istori1 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment