Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception after start under VS2017 #1

Closed
evgenijbystrov opened this issue Aug 8, 2017 · 3 comments
Closed

Exception after start under VS2017 #1

evgenijbystrov opened this issue Aug 8, 2017 · 3 comments

Comments

@evgenijbystrov
Copy link

I installed IsWix after VS2017. I open my project and click Tools>Launch IsWix. After showing message below IsWix opens.

image

@iswix-llc
Copy link
Collaborator

The "Launch IsWiX" takes the active document and passes the filepath to IsWiX. This error occurs when you send it a non-XML or malformed XML document. Be sure to navigate to your ProjectNameMM project and have the ProjectNameMM.wxs document open before launching IsWiX.

I guess I've always tolerated this error UI. I will leave this open and fix it so this is a better looking error box. Pull requests accepted. The code is in the AddIn and NewAddIn projects.

@iswix-llc
Copy link
Collaborator

Actually thats not where the code is. My bad. The stack trace clearly says where it is.

@iswix-llc
Copy link
Collaborator

This technically wasn't an unhandled exception. It was a poorly handled one though. I've changed the dialog to inform the user of the path of the file and that it isn't valid. Then the tool continues on starting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant