[11.0][PORT] base import map port #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because in the custom init function the original (prototype) 'opts' array was mutated, every time the function was called (which happens everytime one opens the import wizard) 3 opts were added, resulting in duplicate map controls. Solve the bug by using concat + reassignment instead of mutation.
LeartS
force-pushed
the
11.0-base_import_map-port
branch
from
84caea3
to
3cbb166
Compare
|
@Railia check functional part please |
Railia
approved these changes
Feb 7, 2018
yelizariev
approved these changes
Apr 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port
base_import_mapto v11. Functionally tested.P.S: Thanks guys for a great module!