🌈 details_model_record field refactor #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolushovAlexandr
force-pushed
the
11.0-base_details-issue_2
branch
from
67e56fd
to
c44e655
Compare
ilmir-k
approved these changes
Aug 8, 2018
|
@KolushovAlexandr change the version please |
…dr/misc-addons into 11.0-base_details-issue_2
yelizariev
requested changes
Aug 9, 2018
base_details/models/base_details.py
Outdated
| details_res_id = fields.Integer(compute="_compute_details", string='Details', store=True) | ||
| details_model_exists = fields.Boolean(compute="_compute_details", string='Details Model Exists', store=True) | ||
| details_model = fields.Selection(selection="_model_selection", string='Model', store=True) | ||
| details_model_record = fields.Reference(selection="_compute_details_model_record", string='Record') |
There was a problem hiding this comment.
Don't use _compute prefix for selection
| @api.depends('details_model_record') | ||
| @api.onchange('details_model_record') | ||
| def _compute_details(self): | ||
| @api.onchange('details_model_exists', 'details_model_record') |
There was a problem hiding this comment.
Why it's onchange and not api.depends?
There was a problem hiding this comment.
@yelizariev Because it should be updated right on the form
…dr/misc-addons into 11.0-base_details-issue_2
…dr/misc-addons into 11.0-base_details-issue_2
yelizariev
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.