Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document use of Storybooks #18

Closed
blauks opened this issue Feb 9, 2021 · 5 comments
Closed

Document use of Storybooks #18

blauks opened this issue Feb 9, 2021 · 5 comments
Assignees
@blauks @emilom
Labels
documentation Improvements or additions to documentation
Projects
Overview
Milestone
Initial project s...

Comments

@blauks
Copy link
Contributor

blauks commented Feb 9, 2021

Document how to set up and use Storybooks.

Helpful notes from @FredrikAugust

Useful points:

  • File name format. With this configuration, they have to be (in effect) *.stories.tsx
  • How does a story look? Perhaps provide an example
  • Should you be able to test container components, or only presenational? If you should be able to test container components, it might be useful to provide a wrapper.
@blauks blauks added the documentation Improvements or additions to documentation label Feb 9, 2021
@blauks blauks added this to the Initial project setup milestone Feb 9, 2021
@blauks blauks self-assigned this Feb 9, 2021
@blauks blauks added this to To do in Overview via automation Feb 9, 2021
@blauks
Copy link
Contributor Author

blauks commented Feb 9, 2021

Will be done after I have finished #1

@blauks blauks moved this from To do to In progress in Overview Feb 15, 2021
@FredrikAugust
Copy link
Contributor

What's the status on this?

@emilom
Copy link
Contributor

emilom commented Feb 15, 2021 •
edited

Im testing some visx now. Will try to set it up with storybooks when I'm done and document it. Probably done by tomorrow afternoon.

@FredrikAugust
Copy link
Contributor

Perfect!:)

@blauks
Copy link
Contributor Author

blauks commented Feb 16, 2021

Storybook wiki @emilom has fixed 🥳

@blauks blauks closed this as completed Feb 16, 2021
Overview automation moved this from In progress to Done Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blauks blauks

@emilom emilom

Labels
documentation Improvements or additions to documentation
Projects
Overview
Done
Milestone
Initial project setup
Development

No branches or pull requests
3 participants
@FredrikAugust @blauks @emilom