Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include LibreOffice in the catalogue #85

Closed
deneb-alpha opened this issue Jun 4, 2019 · 17 comments · Fixed by #184 or tdf/libreoffice-metadata#2
Closed

Include LibreOffice in the catalogue #85

deneb-alpha opened this issue Jun 4, 2019 · 17 comments · Fixed by #184 or tdf/libreoffice-metadata#2
Assignees
@bfabio
Labels
whitelist-request Request for inserting a repo in the crawler whitelist
Milestone
1.4.0

Comments

@deneb-alpha
Copy link
Contributor

The publiccode.yml file for LibreOffice is available here:
https://github.com/tdf/libreoffice-metadata/blob/master/publiccode.yml
@libremente
Copy link
Member

Thanks a lot @deneb-alpha! We'll keep you updated 👍

@deneb-alpha
Copy link
Contributor Author

hi @libremente, do you have any feedback?

@deneb-alpha
Copy link
Contributor Author

deneb-alpha commented Jun 25, 2019 •
edited

Thanks a lot @deneb-alpha! We'll keep you updated 👍

@libremente are there any issue with this publiccode?
I saw that @alranel updated the crawler (crawler/whitelist/thirdparty.yml) and LibreOffice is in the whitelist but the software is not listed in https://developers.italia.it/en/software/

@libremente
Copy link
Member

Hi @deneb-alpha, sorry I thought I had already reported back to you, my bad.
Yes, we added your repo in the whitelist, however the validation failed. The problem is to be found in the way a third party library handles the final + in the SPDX license code. As such, @alranel wrote a patch to fix this issue which has not been merged yet (kyoh86/go-spdx#2). Right now we are waiting for the patch to be merged in order to proceed with the creation of your entry. Sorry for the delay, I'll keep you updated 👍

@deneb-alpha
Copy link
Contributor Author

Thanks for the update @libremente :)

@libremente libremente added the whitelist-request Request for inserting a repo in the crawler whitelist label Jun 27, 2019
@deneb-alpha
Copy link
Contributor Author

hi @libremente, @alranel. Are there any news about this issue?

@deneb-alpha
Copy link
Contributor Author

deneb-alpha commented Jul 22, 2019 •
edited

hi again @libremente, @alranel, @ruphy.
Are there any update?

@libremente
Copy link
Member

Hi @deneb-alpha, the software is in the catalog right now. There is still an issue with the logo rendering but we are working on it. Thanks a lot! 👍

@deneb-alpha
Copy link
Contributor Author

Thank you @libremente!

There is still an issue with the logo rendering but we are working on it. Thanks a lot! 👍

Is there something that I can fix directly for the logo?

@libremente
Copy link
Member

Hi @deneb-alpha, don't worry, the problem is on our side but we are planning to fix it soon!

@libremente
Copy link
Member

Linked to https://github.com/italia/developers-italia-backend/issues/95

@deneb-alpha
Copy link
Contributor Author

Hi @libremente.
The software is in the catalogue but the crawler is still not able to parse the proper version released by The Document Foundation.
The listed version is 2019-09-05 (6.2.7) but the real last available version is 2019-10-17 (6.2.8).

@libremente libremente added this to the 1.4.0 milestone Sep 7, 2020
@bfabio
Copy link
Member

bfabio commented Sep 11, 2020 •
edited

@libremente This PR should fix it but

go-vcsurl's README.md reads

Note that this library only performs syntactic checks and string manipulation, and it does not perform network calls to check that the given resources actually exist.

and that would not be true anymore with that patch. I'm wondering whether we should just move that logic to https://github.com/italia/publiccode-parser-go and respect go-vcsurl's philosophy. WDYT?

@bfabio bfabio moved this from To do to In progress in Developers Italia Sprints #1 Sep 11, 2020
@libremente
Copy link
Member

@bfabio Let's wait for the discussion with the repo maintainer and then will see.

@libremente libremente moved this from In progress to Review in progress in Developers Italia Sprints #1 Sep 14, 2020
bfabio added a commit to bfabio/publiccode-crawler that referenced this issue Sep 22, 2020
@bfabio
Update to publiccode-parser go v1.1.4.
fcedf97 
Update to publiccode-parser go v1.1.4 which uses latest go-vcsurl.

Fix italia#85.
@bfabio bfabio mentioned this issue Sep 22, 2020
Merged
Developers Italia Sprints #1 automation moved this from Review in progress to Done Sep 22, 2020
bfabio added a commit that referenced this issue Sep 22, 2020
@bfabio
Update to publiccode-parser go v1.1.4. (#184)
020dc16 
Update to publiccode-parser go v1.1.4 which uses latest go-vcsurl.

Fix #85.
@bfabio
Copy link
Member

bfabio commented Sep 23, 2020

Reopening because it's still not updated.

@bfabio bfabio reopened this Sep 23, 2020
Developers Italia Sprints #1 automation moved this from Done to In progress Sep 23, 2020
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue Sep 23, 2020
@bfabio
Remove check on url being on the same repo of publiccode.yml.
3862cb3 
Remove the check on `url` and `remoteBaseURL`. This allows
for publiccode.yml to be in a different repository than the
one pointed by `url`.

Related to italia/publiccode-crawler#85.
@bfabio bfabio mentioned this issue Sep 23, 2020
Closed
@libremente libremente mentioned this issue Sep 29, 2020
Merged
@libremente
Copy link
Member

Hi @deneb-alpha, sorry for the extreme delay but we still don't have a proper way to handle this case. We believe that in order to close this issue the best thing to do is to proceed as follows:

  1. Change the url key in this publiccode.yml https://github.com/tdf/libreoffice-metadata/blob/d3080a56c432691d4e4b2e097126df81bd4870ac/publiccode.yml#L8 so that it points to the metadata repository itself.
  2. Insert clear information in the metadata repo's README regarding the place where the code is actually store which is https://git.libreoffice.org/core.

This PR should do it.
Let us know if this workaround makes sense for you.

@libremente
Copy link
Member

Hi @deneb-alpha, let us know if the proposed solution may work. Thanks!

@libremente libremente removed this from In progress in Developers Italia Sprints #1 Oct 12, 2020
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue May 4, 2021
@bfabio
feat: remove the check on url and baseURL
031be05 
This allows for publiccode.yml to be in a different repository than the
one pointed by url.

Related to italia/publiccode-crawler#85
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue May 5, 2021
@bfabio
feat: remove the check on url and baseURL
5116af0 
This allows for publiccode.yml to be in a different repository than the
one pointed by url.

Related to italia/publiccode-crawler#85
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue May 5, 2021
@bfabio
feat: remove the checks on urls
01e4c4e 
This allows for publiccode.yml to be in a different repository than the
one pointed by url and for absolute URLs in publiccode.yml to be
outside of the repository.

Related to italia/publiccode-crawler#85
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue May 18, 2021
@bfabio
feat: remove the checks on urls
2ca3410 
This allows for publiccode.yml to be in a different repository than the
one pointed by url and for absolute URLs in publiccode.yml to be
outside of the repository.

Related to italia/publiccode-crawler#85
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue Jun 16, 2021
@bfabio
feat: remove the checks on urls
f5f94c3 
This allows for publiccode.yml to be in a different repository than the
one pointed by url and for absolute URLs in publiccode.yml to be
outside of the repository.

Related to italia/publiccode-crawler#85
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue Mar 11, 2022
@bfabio
feat: remove the checks on urls
051349e 
This allows for publiccode.yml to be in a different repository than the
one pointed by url and for absolute URLs in publiccode.yml to be
outside of the repository.

Related to italia/publiccode-crawler#85
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue Mar 11, 2022
@bfabio
feat: remove the checks on urls
210392b 
This allows for publiccode.yml to be in a different repository than the
one pointed by url and for absolute URLs in publiccode.yml to be
outside of the repository.

Related to italia/publiccode-crawler#85
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue Feb 18, 2023
@bfabio
feat: remove the checks on urls
4ec1209 
This allows for publiccode.yml to be in a different repository than the
one pointed by url and for absolute URLs in publiccode.yml to be
outside of the repository.

Related to italia/publiccode-crawler#85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bfabio bfabio

Labels
whitelist-request Request for inserting a repo in the crawler whitelist
Projects
None yet
Milestone
1.4.0
3 participants
@bfabio @deneb-alpha @libremente