Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESET and GENERATE buttons breaking DOM #129

Open
tikhsuP opened this issue Feb 18, 2020 · 1 comment
Open

RESET and GENERATE buttons breaking DOM #129

tikhsuP opened this issue Feb 18, 2020 · 1 comment
Labels
needs-triage When a bug cannot be correctly reproduced

Comments

@tikhsuP
Copy link
Contributor

tikhsuP commented Feb 18, 2020

Subject of the issue

The Reset and Generate buttons are breaking the desired DOM for screen sizes less then 580px.
The width of these buttons is fixed at 242px with a fixed gap of 80px between these buttons (i.e. left and right margins of 40px) irrespective of the screen size.
Clearly 40px+242px+80px+242px+40px = 644px exceeds the size of 580px.

Steps to reproduce

Using developer options check the buttons for screen sizes less then 580px.

Expected behavior

The button size should adjust according to the screen size.

This can be done by using a responsive unit like vw (viewport width) rather than a fixed unit like px (pixel(s)) in the class editor_button and removing the width attribute from the class editor_button--custom.

Actual behaviour

For screen sizes less than 580px:

Screenshot (16)

Swipe Left to see this:

Screenshot (17)

@libremente libremente added the needs-triage When a bug cannot be correctly reproduced label Feb 18, 2020
@libremente
Copy link
Member

libremente commented Feb 18, 2020

Hi @tikhsuP thanks for your effort! We will try to triage this issue soon and let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage When a bug cannot be correctly reproduced
Projects
None yet
Development

No branches or pull requests

2 participants