Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS support for logos? #296

Open
matteo-s opened this issue Dec 15, 2023 · 1 comment
Open

CORS support for logos? #296

matteo-s opened this issue Dec 15, 2023 · 1 comment

Comments

@matteo-s
Copy link

Is it possible to add support for CORS to the view serving the logos?
(Example: http://cie-provider.org:8002/static/svg/logo-cie.svg).
When the RP fetches the metadata in order to leverage the logo declared by the OP for its UI it has to download it somewhere and then serve it to the frontend, with all the complexity deriving from having to keep a local copy in sync.
With CORS support the RP could directly use the remote image as-is for its UI.

I don't know if this is something in line with specs, and probably there are security issues involved, so feel free to close it at will.

@peppelinux
Copy link
Member

cors can be enabled in django

please consider that the RP doesn't make any use of the provider's logo, it only provide the logo URI in a UI, then it's the user-agent fetching the logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants