Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread-safe-ness #7

Closed
paulmillar opened this issue Dec 7, 2013 · 3 comments
Closed

Thread-safe-ness #7

paulmillar opened this issue Dec 7, 2013 · 3 comments

Comments

@paulmillar
Copy link

It seems that the DefaultVOMSACParser is not thread safe. As DefaultVOMSValidator (that VOMSValidators returns an instance of) depends on DefaultVOMSACParser, it is also not thread safe.

It would be nice if the JavaDoc mentioned this. For completeness, perhaps it should be mentioned in VOMSValidators, DefaultVOMSValidator and DefaultVOMSACParser.

@andreaceccanti
Copy link
Contributor

Hi Paul,
I would say both are thread safe. Can you clarify ?

@paulmillar
Copy link
Author

Sorry, me bad. Perhaps you could add a comment saying they are thread-safe :-)

You could also mention somewhere that calls make use of mutual exclusion, so requests from multiple threads will be processed serially.

Cheers,

Paul.

@andreaceccanti
Copy link
Contributor

Ok, will improve the docs.
Please refer to this jira issue:
https://issues.infn.it/jira/browse/VOMS-93

Will close this issue.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants