Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Carbon dioxide sensors support #609

Closed
satter opened this issue Jan 7, 2023 · 11 comments
Closed

[Feature] Carbon dioxide sensors support #609

satter opened this issue Jan 7, 2023 · 11 comments
Labels
enhancement New feature or request stale

Comments

@satter
Copy link

satter commented Jan 7, 2023

Problem description

There is currently no support for CO2 sensors in homebride-z2m plugin:
https://z2m.dev/devices/custom_devices_diy/efekta_co2_smart_monitor.html
https://z2m.dev/devices/custom_devices_diy/efekta_iaq.html
https://z2m.dev/devices/titan_products/tpzrco2ht-z3.html
https://z2m.dev/devices/tuya/ts0601_co2_sensor.html

z2m reports co2 levels, both homebridge and apple homekit seems to be supporting co2:
https://developers.homebridge.io/#/service/CarbonDioxideSensor
https://developer.apple.com/documentation/homekit/hmcharacteristictypecarbondioxidelevel

Suggested solution

Looks like new basic sensor needed (similar to carbon_monoxide.ts)

Alternative solutions

No response

Additional context / information

I'm not sure I can help with writing code, but I definitely can test new versions on my co2 sensors

@satter satter added the enhancement New feature or request label Jan 7, 2023
@itavero
Copy link
Owner

itavero commented Jan 7, 2023

I briefly looked at this in the past.
Probably have to add a configurable setpoint for the mandatory Carbon Dioxide Detected characteristic.
Back then, I didn't have a good way to make that configurable, but in the mean time, I've added a mechanism for such things.

@itavero
Copy link
Owner

itavero commented Jan 15, 2023

Just made an implementation with a fixed detection threshold (1200 ppm). Still have to double check it, merge it and release it though.

I don't own a CO2 sensor myself, so I'm hoping my automated test is sufficient.

@itavero
Copy link
Owner

itavero commented Jan 16, 2023

Added initial support in v1.11.0-beta.2 (available on the next release channel).

@satter
Copy link
Author

satter commented Jan 17, 2023

I've installed this version, no errors and co2 is being reported:

Carbon Dioxide Sensor |  
Carbon Dioxide Detected | 0
Carbon Dioxide Level | 443

Will check how it's running for few days and report here again

Thank you!

@satter
Copy link
Author

satter commented Jan 24, 2023

The integration is running without any issues so far: value is reported and sensor alerts are working.

It also would be nice to have configurable detection threshold. 1200 is okay for default but due to personal sensitivity I would like to set detection around 1000 ppm

@stale
Copy link

stale bot commented Mar 11, 2023

It appears that this issue did not have an update in quite some time. Please check if you can provide any additional information to help resolve this issue. If there isn't any activity in the next two weeks, this issue will be closed automatically. Thank you for your contributions!

@stale stale bot added the stale label Mar 11, 2023
@satter
Copy link
Author

satter commented Mar 13, 2023

I think this version could be merged into master

@stale stale bot removed the stale label Mar 13, 2023
@stale
Copy link

stale bot commented Apr 25, 2023

It appears that this issue did not have an update in quite some time. Please check if you can provide any additional information to help resolve this issue. If there isn't any activity in the next two weeks, this issue will be closed automatically. Thank you for your contributions!

@stale stale bot added the stale label Apr 25, 2023
@satter
Copy link
Author

satter commented Apr 27, 2023

it is not stale

@stale stale bot removed the stale label Apr 27, 2023
@itavero
Copy link
Owner

itavero commented Apr 27, 2023

I think this version could be merged into master

It already is. It's just not released in a "non-beta" release yet. Unfortunately there's still some things to improve in the last beta release with regards to adaptive lighting.

@stale
Copy link

stale bot commented Jun 9, 2023

It appears that this issue did not have an update in quite some time. Please check if you can provide any additional information to help resolve this issue. If there isn't any activity in the next two weeks, this issue will be closed automatically. Thank you for your contributions!

@stale stale bot added the stale label Jun 9, 2023
@stale stale bot closed this as completed Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants