Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for uploading a specified list of files #11

Open
leafo opened this issue Nov 28, 2022 · 0 comments · May be fixed by #7
Open

Add support for uploading a specified list of files #11

leafo opened this issue Nov 28, 2022 · 0 comments · May be fixed by #7

Comments

@leafo
Copy link
Member

leafo commented Nov 28, 2022

Add new parameter to /extract that takes an array of files (json array encoded) that should be uploaded.

eg ["helo.mp3", "fjefjkef/efefjewf/wsejf/dog.ogg"]

hryx added a commit to hryx/zipserver that referenced this issue Nov 29, 2022
Closes itchio#11

- Add only_files query param to /extract
- Rename some args and fields for clarity
- Analyzer now inspects file name, not bucket key
- Test extraction results with only_files
- Delete MusicAnalyzer and "contents" query param
hryx added a commit to hryx/zipserver that referenced this issue Nov 29, 2022
Closes itchio#11

- Add only_files query param to /extract
- Test extraction results with only_files

Other details:

- Add Analyzer interface. Originally this was used to handle game and
  music zips differently, but now only GameAnalyzer remains.
- Rename some args and fields for clarity
- Change some structs, namely removing ResourceSpec, which fragmented
  concerns across domains a bit. Logic which affected outgoing headers was
  consolidated under the GameAnalyzer implementation.
- Add optional Metadata field to API result JSON.
- Tests: Replaced assert.NoError() with require.NoError(). The latter stops
  a test immediatly if the assertion fails, which prevents useless and
  noisy panic traces in test output. No dependencies added, already part
  of the testify module.
- Removed unnecessary struct literal type names when they can be inferred,
  per linter.
- Log non-OK notification responses
@hryx hryx linked a pull request Nov 29, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant