Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Arrow with Datetime, add new parser #87

Closed
itchono opened this issue Jul 11, 2023 · 0 comments · Fixed by #91
Closed

Replace Arrow with Datetime, add new parser #87

itchono opened this issue Jul 11, 2023 · 0 comments · Fixed by #91
Assignees
@itchono
Labels
High Priority This item is high priority Small Feature This is a small feature to implement (1 or 2 evenings of work)
Milestone
v1.0.0

Comments

@itchono
Copy link
Owner

itchono commented Jul 11, 2023 •
edited
Loading

Either https://dateparser.readthedocs.io/en/latest/ or https://pypi.org/project/timelength/

  • Arrow's main functionality is not worth it for the extra dependency
  • There's a lot of funk with the current implementation anyways
  • Discord uses UTC timestamps anyways
  • Remove arrow, turn defer date parsing to a separate parser

Make it more similar to Comrade V5 format. I think timelength is probably the closest.
@itchono itchono added Small Feature This is a small feature to implement (1 or 2 evenings of work) High Priority This item is high priority labels Jul 11, 2023
@itchono itchono added this to the v1.0.0 milestone Jul 11, 2023
@itchono itchono self-assigned this Jul 11, 2023
@itchono itchono changed the title Replace Arrow with Datetime, add dateparser Replace Arrow with Datetime, add new parser Jul 11, 2023
@itchono itchono mentioned this issue Jul 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itchono itchono

Labels
High Priority This item is high priority Small Feature This is a small feature to implement (1 or 2 evenings of work)
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Overhaul Reminders System itchono/comrade-next
1 participant
@itchono