Improve replace mode #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a replaceBuf field into the `window` struct to represent a "pending" (or yet-to-be-committed) replace buffer. * Editing bytes in replace mode addresses the pending replace buffer instead of treating window.buffer directly. * When users exit from replace mode, the pending replace buffer is "committed" to window.buffer. * window.state pretends that the pending replace buffer is committed by modifying Bytes and Length of WindowState.
|
Great, thanks. I'll work on in a few days. |
Merged
|
Merged with commits in #15. After all I implemented the temporary bytes in Buffer but I respect your contribution. If there're still some bug (especially panic crash) in the master branch, please let me know. Thanks. |
|
Great job 👍 Hooray! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rcommand does nothing for empty windows.But there are some issues:
integer divide by zero) occurs when interleaved withxcommand.I guess
Buffer.Replaceshould increment the length whenoffsetfor replacing equalslengthso that inbuffer/buffer_test.go,TestBufferReplace's last 3 test cases should setlento 17.bed/buffer/buffer_test.go
Lines 400 to 402 in 517e02f
Related to #12.