fix(index): resolves #6 for default values

iteam-software · Apr 23, 2020 · 9568583 · 9568583
1 parent da08606
commit 9568583
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 3 deletions.
diff --git a/src/__tests__/index.test.js b/src/__tests__/index.test.js
@@ -21,7 +21,6 @@ describe("Gatsby Node Hook", () => {
         },
       ],
     };
-
     const helpers = {
       createNodeId: jest.fn(),
       createContentDigest: jest.fn(),
@@ -36,4 +35,56 @@ describe("Gatsby Node Hook", () => {
       done();
     });
   });
+
+  test("should run when sites is undefined", (done) => {
+    // Arrange
+    const config = {
+      host: "iteamnm.sharepoint.com",
+      appId: process.env.AppId,
+      appSecret: process.env.AppSecret,
+      tenantId: process.env.TenantId,
+    };
+    const helpers = {
+      createNodeId: jest.fn(),
+      createContentDigest: jest.fn(),
+      actions: {
+        createNode: jest.fn(),
+      },
+    };
+
+    // Act & Assert
+    sourceNodes(helpers, config, () => {
+      expect(helpers.actions.createNode).not.toHaveBeenCalled();
+      done();
+    });
+  });
+
+  test("should run when lists is undefined", (done) => {
+    // Arrange
+    const config = {
+      host: "iteamnm.sharepoint.com",
+      appId: process.env.AppId,
+      appSecret: process.env.AppSecret,
+      tenantId: process.env.TenantId,
+      sites: [
+        {
+          name: "gatsby-source-sharepoint-online",
+          relativePath: "sites/gatsby-source-sharepoint-online",
+        },
+      ],
+    };
+    const helpers = {
+      createNodeId: jest.fn(),
+      createContentDigest: jest.fn(),
+      actions: {
+        createNode: jest.fn(),
+      },
+    };
+
+    // Act & Assert
+    sourceNodes(helpers, config, () => {
+      expect(helpers.actions.createNode).toHaveBeenCalledTimes(1);
+      done();
+    });
+  });
 });
diff --git a/src/index.js b/src/index.js
@@ -17,7 +17,7 @@ exports.sourceNodes = function sourceNodes(helpers, config, callback) {
     createContentDigest,
     actions: { createNode },
   } = helpers;
-  const { plugins, host, sites, ...creds } = config;
+  const { plugins, host, sites = [], ...creds } = config;
   const client = createClient(creds);
 
   /**
@@ -29,6 +29,8 @@ exports.sourceNodes = function sourceNodes(helpers, config, callback) {
       throw new Error("site must be defined.");
     }
 
+    const { lists = [] } = site;
+
     /**
      * Process a site list.
      * @param {string} siteId The id of the site this list belongs to.
@@ -76,7 +78,7 @@ exports.sourceNodes = function sourceNodes(helpers, config, callback) {
           },
         });
 
-        return Promise.all(site.lists.map((list) => processList(siteId, list)));
+        return Promise.all(lists.map((list) => processList(siteId, list)));
       });
   };