Skip to content

Saves passphrase for private key in keychain regardless if login fails #10526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cyberduck opened this issue Oct 30, 2018 · 1 comment
Closed

Saves passphrase for private key in keychain regardless if login fails #10526

cyberduck opened this issue Oct 30, 2018 · 1 comment
Assignees
@dkocher
Labels
bug fixed sftp SFTP Protocol Implementation
Milestone
6.9.0

Comments

@cyberduck
Copy link
Collaborator

1bb2969 created the issue

When using key-based authentication to establish an SFTP connection, if the user enters his or her passphrase incorrectly and checks the box to save the passphrase in the system keychain, the passphrase is saved even though the connection is unsuccessful. This results in an incorrect passphrase being stored in the keychain, which can cause confusion for the user. Cyberduck should only store the passphrase if the connection attempt succeeds, as is standard behavior for a modern web browser.
@cyberduck
Copy link
Collaborator Author

@dkocher commented

In d47ced2.

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dkocher dkocher

Labels
bug fixed sftp SFTP Protocol Implementation
Projects
None yet
Milestone
6.9.0
Development

No branches or pull requests
2 participants
@dkocher @cyberduck