Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saves passphrase for private key in keychain regardless if login fails #10526

Closed
cyberduck opened this issue Oct 30, 2018 · 1 comment
Closed

Saves passphrase for private key in keychain regardless if login fails #10526

cyberduck opened this issue Oct 30, 2018 · 1 comment
Assignees
Labels
bug fixed sftp version:6.8.2
Milestone

Comments

@cyberduck
Copy link
Collaborator

@cyberduck cyberduck commented Oct 30, 2018

1bb2969 created the issue

When using key-based authentication to establish an SFTP connection, if the user enters his or her passphrase incorrectly and checks the box to save the passphrase in the system keychain, the passphrase is saved even though the connection is unsuccessful. This results in an incorrect passphrase being stored in the keychain, which can cause confusion for the user. Cyberduck should only store the passphrase if the connection attempt succeeds, as is standard behavior for a modern web browser.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Dec 11, 2018

@dkocher commented

In d47ced2.

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed sftp version:6.8.2
Projects
None yet
Development

No branches or pull requests

2 participants