Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrupted files downloaded #7641

Closed
cyberduck opened this issue Nov 26, 2013 · 8 comments
Closed

Corrupted files downloaded #7641

cyberduck opened this issue Nov 26, 2013 · 8 comments
Assignees
Labels
Milestone

Comments

@cyberduck
Copy link
Collaborator

@cyberduck cyberduck commented Nov 26, 2013

bc41a8a created the issue

In trying to move a web site from one server to another we discovered that some of the files were trashed once they got there. We tracked it down to downloading under version 4.4.2. I've attached one of the files that was getting trashed - both the original and the trashed version. The end of the downloaded file is messed up with random bytes. It could be something like a file encoding issue, but the files should be utf8 which is what 'default' used.

  • The process was downloading from a linux server to a mac. Then uploading to a new linux server. But the file is corrupted on the initial download. Also doing an Edit (which downloads the file to textmate) shows the file as corrupt.

  • The file is not actually corrupted on the server. SSH in and cat the file shows it correctly.

  • It's not random. The same files will trash the same exact way each time we download them. Even if they are in different folders. So we suspect it has to do with the contents of the file or the order of the characters or the length of the files. But we don't know.

  • These are text files. PHP code and java. But also we did see a .zip file got corrupted on download. But not every zip. Not every text file. About 10 in 200 files on my particular web site.

  • We tried from two different macs with two different versions of OS - downloading from the same server. One mac is 10.7.5. Don't know the other one version. Both macs with cyberduck 4.4.2 trash those particular files.

  • Using either ForkLift or Cyberduck (13582) 4.4.1 the file downloads correctly with the same settings from that same server.

  • We also tried from two different linux servers. Using 4.4.2 that file is always corrupt in the same way, coming down from either of my servers. The servers are both CENTOS 6.4 x86_64 standard but are located in different states and have different versions of OS. One has webmin installed and one has cpanel installed.


Attachments

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Nov 26, 2013

@dkocher commented

What protocol do you use to connect to the server?

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Nov 26, 2013

@dkocher commented

Can you please post the transcript from the log drawer (⌘-L) of the Transfers window for such a corrupt download.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Nov 26, 2013

@dkocher commented

The regression must have been introduced in 474238b. Added test in 8e4a9ba.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Nov 27, 2013

@dkocher commented

Rewrote more tests for coverage in 3171898.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Nov 27, 2013

@dkocher commented

Added failing test in 5a1a839.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Nov 27, 2013

@dkocher commented

Fixed in f50ea1a by removing buffers.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Nov 27, 2013

@dkocher commented

Additional fix in 3751955 by always reading full chunk size.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Dec 1, 2013

@dkocher commented

#7656 closed as duplicate.

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants