Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unregister fails: is still running a job #1103

Closed
DavidGOrtega opened this issue Jul 25, 2022 · 4 comments
Closed

Unregister fails: is still running a job #1103

DavidGOrtega opened this issue Jul 25, 2022 · 4 comments
Labels

Comments

@DavidGOrtega
Copy link
Contributor

Runner fails unregistering because the job is still running.
The two plausible solutions might be:

  • wait until job is done
  • cancel the workflow prior to unregister
@dacbd
Copy link
Contributor

dacbd commented Jul 25, 2022

👎 canceling the workflow prior to unregistering.
users could have other jobs running in that workflow that arent on that runner.

Have you or how can you reproduce this failure mode?

@0x2b3bfa0
Copy link
Member

What if you just kill the self-hosted runner process prior to unregistering the runner?

@dacbd
Copy link
Contributor

dacbd commented Jul 25, 2022

Is this for a spot termination?

  1. working on a job
  2. spot terminate signal received.
  3. tries to unregister as a part of the shutdown, but the job is still running?

I agree; terminate the runner process before unregistering the runner. you may need a grace period for github to know, but I think that even if that fails it shouldn't have any real impact on anything?

Also, a non-issue if you use --single for spot instances.

@0x2b3bfa0
Copy link
Member

Closed with the #1255 saga, unless proven otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants