Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of images fail to load in one report #1348

Closed
shortcipher3 opened this issue Feb 10, 2023 · 3 comments · Fixed by #1350
Closed

Lots of images fail to load in one report #1348

shortcipher3 opened this issue Feb 10, 2023 · 3 comments · Fixed by #1350
Assignees
Labels
ci-gitlab cml-comment Subcommand cml-publish Subcommand external-request You asked, we did

Comments

@shortcipher3
Copy link

Running some cml comment with a report containing maybe 10 images that I wanted displayed, it is cutting off the last two (it varies a little, sometimes just one, sometimes more), when I look at the markdown for the images that failed to display I see that the images that failed to upload have the original name, rather than the updated url.

After breaking up the report into multiple comments each with fewer images I was able to get all 10 comments to load.

I'm guessing there is a limit, it might be nice to call that out as a warning or error - if you can help users catch that early.

@dacbd
Copy link
Contributor

dacbd commented Feb 10, 2023

@shortcipher3 thanks for making an issue, I want to confirm that you were using the GitLab only --publish-native flag correct?

I believe you are likely correct and that the comment reached some kind of file size limit due to --publish-native

@shortcipher3
Copy link
Author

Yes, that is correct, I was using gitlab with the --publish-native flag.

@dacbd
Copy link
Contributor

dacbd commented Feb 21, 2023

@shortcipher3 please note that this hasn't been released yet but should be shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-gitlab cml-comment Subcommand cml-publish Subcommand external-request You asked, we did
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants