Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double jobs #48

Closed
dmpetrov opened this issue Apr 13, 2020 · 2 comments · Fixed by #60
Closed

Double jobs #48

dmpetrov opened this issue Apr 13, 2020 · 2 comments · Fixed by #60

Comments

@dmpetrov
Copy link
Member

Two jobs are triggered because of:

   on: [push, pull_request]
@DavidGOrtega
Copy link
Contributor

pull_request should not run by

if (is_pr && (await check_ran_ref({ ref }))) {
    console.log(
      'This ref is running or has runned another check. Cancelling...'
    );
    return;
  }

did you notice the second run? can you please put the logs of pull_request here?

Also that check would not be necessary if we wait the push to train before the PR since dvc would handle it with dvc_repro, that for me would be the ideal scenario.

@dmpetrov
Copy link
Member Author

https://github.com/dmpetrov/mnist_keras/pull/1
See first 2-3 runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants