Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong item highlighted in the right menu #1306

Closed
iKBAHT opened this issue May 18, 2020 · 1 comment
Closed

Wrong item highlighted in the right menu #1306

iKBAHT opened this issue May 18, 2020 · 1 comment
Labels
duplicate This issue or pull request already exists. 🐛 type: bug Something isn't working. website: eng-doc DEPRECATED JS engine for /doc

Comments

@iKBAHT
Copy link
Contributor

iKBAHT commented May 18, 2020

Str:

  1. go to https://dvc.org/doc/command-reference/diff
  2. click to "Example" item in the right menu

Actual:
"Example: Checking workspace changes" item will be highlighted

Expected:
"Example" item will be highlighted

Some ideas:
https://github.com/iterative/dvc.org/blob/master/src/components/Documentation/RightPanel/index.tsx#L44
A peculiarity of the navigation algorithm
@iKBAHT iKBAHT mentioned this issue May 18, 2020
Merged
@jorgeorpinel jorgeorpinel added 🐛 type: bug Something isn't working. website: eng-doc DEPRECATED JS engine for /doc duplicate This issue or pull request already exists. labels May 18, 2020
@jorgeorpinel
Copy link
Contributor

I think this is basically a duplicate of iterative/gatsby-theme-iterative#38. @iKBAHT please add details in that one and close this one? thanks

@iKBAHT iKBAHT closed this as completed May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists. 🐛 type: bug Something isn't working. website: eng-doc DEPRECATED JS engine for /doc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iKBAHT @jorgeorpinel