Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data status: doesn't work when using dvc with hydra when params.yaml is present, but not staged #10160

Open
Danila89 opened this issue Dec 13, 2023 · 1 comment
Labels
p2-medium Medium priority, should be done, but less important ui user interface / interaction

Comments

@Danila89
Copy link

Description

dvc data status fails when hydra integration is involved.

Reproduce

git clone https://github.com/Danila89/dvc_empty.git && cd dvc_empty && dvc exp run -n something && dvc data status

Expected

dvc data status output

Environment information

Output of dvc doctor:

(base) danila.savenkov@RS-UNIT-0099 dvc_empty % dvc doctor
DVC version: 3.33.3 (pip)
-------------------------
Platform: Python 3.10.9 on macOS-13.3.1-arm64-arm-64bit
Subprojects:
        dvc_data = 2.22.6
        dvc_objects = 1.4.9
        dvc_render = 1.0.0
        dvc_task = 0.3.0
        scmrepo = 1.5.0
Supports:
        http (aiohttp = 3.8.4, aiohttp-retry = 2.8.3),
        https (aiohttp = 3.8.4, aiohttp-retry = 2.8.3),
        s3 (s3fs = 2023.5.0, boto3 = 1.26.76)
Config:
        Global: /Users/danila.savenkov/Library/Application Support/dvc
        System: /Library/Application Support/dvc
Cache types: reflink, hardlink, symlink
Cache directory: apfs on /dev/disk3s3s1
Caches: local
Remotes: None
Workspace directory: apfs on /dev/disk3s3s1
Repo: dvc, git
Repo.site_cache_dir: /Library/Caches/dvc/repo/64bbbded2e55036b006c56ceaefa98e1

Additional Information (if any):

Interesting detail: if params.yaml is committed to git - everything works:
git clone https://github.com/Danila89/dvc_empty.git && cd dvc_empty && git pull --all && git checkout dvc_data_status_issue && dvc data status

@dberenbaum
Copy link
Contributor

Interesting detail: if params.yaml is committed to git - everything works:

That makes sense because dvc data status is comparing changes in the workspace to the Git HEAD (like a companion to git status). Once again, DVC considers the Git HEAD invalid here because there's no params.yaml. So I would say the behavior is expected, but we need a better error message.

@dberenbaum dberenbaum added p2-medium Medium priority, should be done, but less important ui user interface / interaction labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-medium Medium priority, should be done, but less important ui user interface / interaction
Projects
None yet
Development

No branches or pull requests

2 participants