Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3: add option to disable ssl verification #1394

Closed
efiop opened this issue Dec 1, 2018 · 4 comments
Closed

s3: add option to disable ssl verification #1394

efiop opened this issue Dec 1, 2018 · 4 comments
Labels
enhancement Enhances DVC

Comments

@efiop
Copy link
Member

efiop commented Dec 1, 2018

I.e.

s3 = boto3.client('s3', verify=False)

Might be useful for people with strict ssl policies at a workplace.

@efiop efiop added the enhancement Enhances DVC label Dec 1, 2018
@efiop efiop modified the milestones: Queue, 0.22.1 Dec 1, 2018
@ghost
Copy link

ghost commented Dec 5, 2018

@efiop , could you describe a little bit more the use case?

I don't think it should be a good idea to disable verifying the certificates; there's another option use_ssl, tho, that will disable SSL.

For the ones who have custom endpoints without SSL certificates, for example: http://localhost:8000 it will not force SSL usage.

@ghost
Copy link

ghost commented Dec 5, 2018

In case we implement this, I'm imagining something like: dvc remote modify bucket disable_ssl true, what do you think?

@efiop
Copy link
Member Author

efiop commented Dec 5, 2018

I was actually thinking about something like dvc remote modify mys3remote verify_ssl false(true by default`).

@efiop
Copy link
Member Author

efiop commented Dec 12, 2018

Fixed by #1428

@efiop efiop closed this as completed Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC
Projects
None yet
Development

No branches or pull requests

1 participant