-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use progress bar for dvc pull/checkout #1643
Comments
Related #1430 |
@efiop, @shcheklein Would we rather have our own progress bar, or can we consider 3rd party, like https://github.com/tqdm/tqdm ? It has MIT license, so I guess it would be ok to use it. |
Don't see any reasons to do our own library. Looks like a great library, @pared ! |
@pared , I like By the way, |
We did try tqdm in the early stages of dvc, but couldn't make it work the way we wanted with multithreading and stuff. But maybe it will fit into the current dvc, there have been so many changes since then after all 🙂 |
I forgot that we already have progress bar. I assume due to resons mentioned by @efiop. In that case I am not sure that introducing new dependency is good idea. We should probably stay with our current progress bar, or try to apply tqdm everywhere. In 2 case I think we should treat it as separate task. What do you guys think? |
Also there is one more thing to discuss before I do something:
Those infos will break display of progress bar, and result partial progress bar updates mixed with logged information. How would we like to process from here?
What do you guys think? |
@pared I agree, migrating to tqdm is a separate task, unless our current progress bar is not suitable for the current task and tqdm is. Have you tested that though? If recent progress bar changes didn't break anything, it should print info() cleanly if we are during progress bar print and start progress bar over. It is hard to explain in words, need to try and see :) Basically, it looks like progress bar is a last dynamic line in your terminal and all info()'s and debug()'s and etc are printed above it. |
As per discussion here:
https://discordapp.com/channels/485586884165107732/485586884165107734/547833091264086067
One of the suggestions is to use npm-style progress bar instead of printing the files one by one. Something similar to this:
https://terminalizer.com/view/1f4a8cae675
The text was updated successfully, but these errors were encountered: