-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
progress: use logger.info()
instead of print()
#1724
Comments
logger.info()
instead of print()
logger.info()
instead of print()
logger.info()
instead of print()
@pared can I take this issue? Think it can be done quite quickly |
@J0 sure, if it is unassigned feel free to go, thanks for notice :) |
I cannot assign you, @efiop can you do that? |
@pared Unfortunately I can't 🙁 Only members can be assigned to a task. |
@J0 I've sent you a collaborator invite. After that we will be able to assign ticket to you. Most likely, you will be able to take them on your own :). |
@efiop I would like to trouble you for help/advice on this issue. I was under the impression that naively changing the print static method in
to
would solve the issue but unfortunately, this causes most of the tests to break. Any idea what might be going on and any suggestions on how I should proceed? |
Sure! I'll go work on the other issues I've been assigned to first |
This is no longer needed. Proper solution will be introduced in #2148 |
Progress bar writes directly to
sys.stdout
, logger does not.Need to make progress bar use
logger.info()
instead ofprint()
The text was updated successfully, but these errors were encountered: