Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: update completion scripts for bash and zsh #1732

Closed
ghost opened this issue Mar 15, 2019 · 4 comments
Closed

scripts: update completion scripts for bash and zsh #1732

ghost opened this issue Mar 15, 2019 · 4 comments
Labels
enhancement Enhances DVC good first issue help wanted p3-nice-to-have It should be done this or next sprint

Comments

@ghost
Copy link

ghost commented Mar 15, 2019

Files are located in: https://github.com/iterative/dvc/tree/master/scripts/completion

There are some missing flags and maybe some commands that weren't contemplated when the scripts were written.

Any other improvements are more than welcome :)

@ghost ghost self-assigned this Mar 17, 2019
@efiop efiop added the p3-nice-to-have It should be done this or next sprint label Mar 20, 2019
@bayethiernodiop
Copy link

gonna try to work on this in my spare time(little busy though)

@shcheklein
Copy link
Member

@bayethiernodiop that would be great! @MrOutis do we want to reassign it then?

@ghost
Copy link
Author

ghost commented Mar 21, 2019

@bayethiernodiop , sorry I didn't see your message before!
I already worked on a patch for it, but it would be great if you can review my pull request :) !

There are some things that we are missing on zsh, tho, like completion for sub-sub-commands (e.g. dvc remote add <tab> or dvc cache dir <tab>)

#1764

Please, @bayethiernodiop , feel free to leave any comments!

@bayethiernodiop
Copy link

happy to hear that. Nice work @MrOutis i really wanted that feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC good first issue help wanted p3-nice-to-have It should be done this or next sprint
Projects
None yet
Development

No branches or pull requests

3 participants