Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort files by size before push/pull #528

Closed
efiop opened this issue Mar 8, 2018 · 9 comments
Closed

Sort files by size before push/pull #528

efiop opened this issue Mar 8, 2018 · 9 comments
Assignees
@efiop
Labels
enhancement Enhances DVC

Comments

@efiop
Copy link
Member

efiop commented Mar 8, 2018

No description provided.

@efiop efiop added the enhancement Enhances DVC label Mar 8, 2018
@efiop efiop self-assigned this Mar 8, 2018
@efiop
Copy link
Member Author

efiop commented Mar 8, 2018

Related to #522

@efiop efiop closed this as completed in 2e21c39 Mar 8, 2018
@efiop
Copy link
Member Author

efiop commented Mar 9, 2018

Sorry, closed by accident.

@efiop efiop reopened this Mar 9, 2018
@efiop
Copy link
Member Author

efiop commented Jul 1, 2018

No longer relevant with new design. Closing.

@efiop efiop closed this as completed Jul 1, 2018
@casperdcl casperdcl mentioned this issue Apr 5, 2020
Merged
3 tasks
@casperdcl
Copy link
Contributor

reopening due to #3594 (comment) and #3594 (comment). Basically:

  • slight speed improvement
  • reducing whitespace between nested bars
  • to implement this, sizes aren't currently available for pull but they'll be required anyway for other thigs (e.g. Add summary to dvc status -c [target]  #3568)

@casperdcl casperdcl reopened this Apr 25, 2020
@efiop
Copy link
Member Author

efiop commented Dec 7, 2020 •
edited

Closing in favor of #3682 , as that will be a better solution overall

@efiop efiop closed this as completed Dec 7, 2020
@shcheklein
Copy link
Member

Closing in favor of #3682 , as that will be a better solution overall

💅 #3682 is not about performance though. Certain scenarios can benefit a lot from sorting by size on download/upload.

@efiop
Copy link
Member Author

efiop commented Dec 8, 2020

@shcheklein Single progress bar based on total size is what we are going to get for push/pull, especially when we implement the chunking.

@shcheklein
Copy link
Member

@efiop yep, not sure I got the idea how is it related to the performance though? I was not referring to UI/UX (single vs multiple bars)

@efiop
Copy link
Member Author

efiop commented Dec 8, 2020

@shcheklein Ah, I misunderstood. The single pbar is also related to chunking from #829 , so without big files there is nothing to prioritize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efiop efiop

Labels
enhancement Enhances DVC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shcheklein @efiop @casperdcl