Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import-url: --no-download and dvc commit #8173

Closed
dberenbaum opened this issue Aug 23, 2022 · 2 comments
Closed

import-url: --no-download and dvc commit #8173

dberenbaum opened this issue Aug 23, 2022 · 2 comments
Labels
p2-medium Medium priority, should be done, but less important

Comments

@dberenbaum
Copy link
Contributor

What is the expected behavior of dvc commit when a repo has partial imports? Currently it will fail because there is no output file in the workspace

$ cat file.dvc
md5: 750c9e509a218cbbcde864ce15515c0d
frozen: true
deps:
- etag: '0x8DA79D118EC7839'
  size: 2
  path: remote://azure/dir/file
outs:
- path: file

$ dvc commit
outputs ['file'] of stage: 'file.dvc' changed. Are you sure you want to commit it? [y/n] y
ERROR: failed to commit - output 'file' does not exist

It seems to me that committing a partial import should just be a no-op and silently pass?

Originally posted by @pmrowla in #8024 (comment)

@shcheklein
Copy link
Member

What happens if it's just a regular output that is missing in the workspace? Also an error?

From the top of my head it's fine to throw an error, may be put a flag to silence these kind of errors (and add to the error message)

@dberenbaum dberenbaum added the p2-medium Medium priority, should be done, but less important label Aug 24, 2022
@dberenbaum
Copy link
Contributor Author

What happens if it's just a regular output that is missing in the workspace? Also an error?

Yes.

I agree that it's not critical to address this, and it seems consistent with current behavior as is.

However, I like the idea of it being a no-op and silently passing. It's a step towards being smarter about missing outputs instead of always throwing an error. Why should dvc commit throw an error for a valid workflow?

@dberenbaum dberenbaum closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-medium Medium priority, should be done, but less important
Projects
None yet
Development

No branches or pull requests

2 participants