Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp push: default to --rev HEAD #9595

Closed
dberenbaum opened this issue Jun 13, 2023 · 4 comments · Fixed by #9631
Closed

exp push: default to --rev HEAD #9595

dberenbaum opened this issue Jun 13, 2023 · 4 comments · Fixed by #9631
Labels
A: experiments Related to dvc exp p1-important Important, aka current backlog of things to do

Comments

@dberenbaum
Copy link
Contributor

Let's make dvc exp push origin push all experiments derived from the HEAD revision by default. This is especially useful in CI, where it's common to want to push the latest experiment and dvc exp push origin --rev HEAD feels like it's too complicated.

See discussion in https://iterativeai.slack.com/archives/C01116VLT7D/p1686321601633079.

@dberenbaum dberenbaum added p1-important Important, aka current backlog of things to do A: experiments Related to dvc exp labels Jun 13, 2023
@shcheklein
Copy link
Member

Also, dvc exp push origin --rev HEAD seems to be not working on CI. I didn't manage to make it work the last time I tried (I didn't have enough time unfortunately). It comes down to the supported E2E scenarios and making sure that they are not broken / fairly simple to use.

@dberenbaum
Copy link
Contributor Author

@shcheklein Added a separate ticket to discuss the more general problem.

@shcheklein
Copy link
Member

@dberenbaum thanks a lot for moving forward this quickly! qq - do we plan to also make origin a default (similar to Git)?

@dberenbaum
Copy link
Contributor Author

No, we discussed (and have discussed before) but decided not to for now for a few reasons:

  1. Breaking change (because it's a positional arg, origin would be misread as an exp name) - CI/scripts will break, and Studio and VS Code need to coordinate this change
  2. Potentially confusing behavior for what remote to track
  3. Consistency with git (without upstream tracking branch, git will similarly fail)
  4. Consistency with dvc exp list
  5. Doesn't feel as painful as --rev HEAD
  6. Bias towards explicit over implicit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Related to dvc exp p1-important Important, aka current backlog of things to do
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants